----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56053/#review164887 -----------------------------------------------------------
LGTM, but you're mostly just updating the tests to uses VALUE, and there's only a single test for the REFERENCE type. Is there nothing else we should test there? - Adam B On Feb. 8, 2017, 10:34 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56053/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 10:34 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod > Kone. > > > Bugs: MESOS-7009 > https://issues.apache.org/jira/browse/MESOS-7009 > > > Repository: mesos > > > Description > ------- > > This patch adds a field of type `Secret` to the > `Environment` protobuf message, enabling the passing > of secrets into the environments of executors and > tasks. Additional validation and test code is added > as well. > > > Diffs > ----- > > include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a > include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 > src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 > src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c > src/tests/health_check_tests.cpp 7b6a803a28b2e4f6c27e9a0c4f668350ec2d5a81 > src/tests/master_validation_tests.cpp > 0c2649089d7fd29eb021ac75c71e6a74368577dc > src/tests/slave_validation_tests.cpp > 3d17799ed04951fb56524db0f5d89347192300b2 > > Diff: https://reviews.apache.org/r/56053/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
