----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56053/#review165782 -----------------------------------------------------------
include/mesos/v1/mesos.proto (line 1911) <https://reviews.apache.org/r/56053/#comment237639> Can you add a TODO here to remove the default in Mesos 2.1? Ideally, you should file a ticket with target version set to 2.1. src/common/validation.cpp (line 154) <https://reviews.apache.org/r/56053/#comment237637> Can you add a NOTE here that if an user sets a new enum value (FOO) that this code doesn't know about yet (e.g., during upgrade), then instead of considering at as UNKNOWN we consider it as VALUE? I guess it is safe because that will most likely result in #156; unless the user mistakenly set type to `FOO` and `value` to non-empty. src/common/validation.cpp (lines 168 - 175) <https://reviews.apache.org/r/56053/#comment237638> This should only happen when an user explicitly sets type as UNKNOWN. So we shouldn't check `has_value` but always return Error. src/tests/slave_validation_tests.cpp (line 145) <https://reviews.apache.org/r/56053/#comment237641> Why is this test here instead of master validationt ests? Doesn't this validation happen in master? src/tests/slave_validation_tests.cpp (lines 218 - 235) <https://reviews.apache.org/r/56053/#comment237640> this needs to be updated per the above comment. - Vinod Kone On Feb. 15, 2017, 11:20 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56053/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 11:20 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod > Kone. > > > Bugs: MESOS-7009 > https://issues.apache.org/jira/browse/MESOS-7009 > > > Repository: mesos > > > Description > ------- > > This patch adds a field of type `Secret` to the > `Environment` protobuf message, enabling the passing > of secrets into the environments of executors and > tasks. Additional validation and test code is added > as well. > > > Diffs > ----- > > include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a > include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 > src/common/validation.hpp 7946f06cf17c05893ff80179c9d14b5f1f4023ef > src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 > src/tests/check_tests.cpp b5a5d8e80c80b480992a3c8160ee7d0e4443111c > src/tests/health_check_tests.cpp 476e04a12f885e5060a6e838b82ee599594c96f7 > src/tests/master_validation_tests.cpp > fd1f4a6cf0661351e265e50da1bd6ea04ed13d26 > src/tests/slave_validation_tests.cpp > 3d17799ed04951fb56524db0f5d89347192300b2 > > Diff: https://reviews.apache.org/r/56053/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
