----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56505/#review165021 -----------------------------------------------------------
Bad patch! Reviews applied: [56505, 56504, 55749, 55550, 55549, 55547, 55546, 55543, 55162, 55030, 55024, 55023, 55022] Failed command: python support/apply-reviews.py -n -r 55030 Error: 2017-02-09 22:37:20 URL:https://reviews.apache.org/r/55030/diff/raw/ [3711/3711] -> "55030.patch" [1] error: patch failed: 3rdparty/libprocess/src/tests/CMakeLists.txt:16 error: 3rdparty/libprocess/src/tests/CMakeLists.txt: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/17042/console - Mesos Reviewbot On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56505/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 5:57 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-3098 > https://issues.apache.org/jira/browse/MESOS-3098 > > > Repository: mesos > > > Description > ------- > > This commit will introduce the changes to the Mesos Docker interfaces > required to use the Docker executor to run Windows Containers in the > Mesos agent. In particular, since Windows Containers use named pipes to > connect do the Docker host, rather than a socket, we introduce the > plumbing to default to a named pipe connection when invoking the > `docker` command. > > This work constitutes the beginning of the end of the work that will > eventually result in Mesos support of Windows Containers. > > This review is partially based on r/52364, which was the work of Daniel > Pravat. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/slave/constants.hpp 1159ac3b1f8797a847a6f5679045434064a519e9 > src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d > src/slave/flags.cpp 71935dea0f898d4594de9a5d8a3d1c7fc1a21606 > src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906 > > Diff: https://reviews.apache.org/r/56505/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
