----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56808/#review166046 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 134) <https://reviews.apache.org/r/56808/#comment237949> Any reason you need this state? Can 'state' just been a boolean (i.e., `destorying`)? src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 498) <https://reviews.apache.org/r/56808/#comment237950> Why remove case (1) in the original comment? I think case 1) and case 2) in the original comment are for different cases. src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 547) <https://reviews.apache.org/r/56808/#comment237951> Not yours, please use const ref here. - Jie Yu On Feb. 18, 2017, 1:54 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56808/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2017, 1:54 a.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Fixed nested container agent flapping issue after reboot. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > ff52e35ac44fea70fe2031e6ac537c613c57f50f > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 8c20d4077859d437999467d045dfd500c1e576dd > > Diff: https://reviews.apache.org/r/56808/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
