----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56808/ -----------------------------------------------------------
(Updated Feb. 21, 2017, 1:54 p.m.) Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues. Repository: mesos Description (updated) ------- When recovering containers in provisioner, there is a particular case that after the machine reboots the container runtime directory and slave state is gone but the provisioner directory still exists since it is under the agent work_dir(e.g., agent work_dir is /var/lib/mesos). Then, all checkpointed containers will be cleaned up as unknown containers in provisioner during recovery. However, the semantic that a child container is always cleaned up before its parent container cannot be guaranteed for this particular case. Ideally, we should put the provisioner directory under the container runtime dir but this is not backward compactible. It is an unfortunate that we have to make the provisioner::destroy() to be recursive. Diffs (updated) ----- src/slave/containerizer/mesos/provisioner/provisioner.hpp ff52e35ac44fea70fe2031e6ac537c613c57f50f src/slave/containerizer/mesos/provisioner/provisioner.cpp 8c20d4077859d437999467d045dfd500c1e576dd Diff: https://reviews.apache.org/r/56808/diff/ Testing ------- make check Thanks, Gilbert Song