> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1713 > > <https://reviews.apache.org/r/55887/diff/3/?file=1627222#file1627222line1713> > > > > s/tasks(s) // > > because it's already in `taskOrTaskGroup`? > > > > Also s/WARNING/ERROR/ because this is actually an error, if we do log > > it.
I changed to `ERROR`, however nothing is logged on the master when authorization fails. So we might as well do the same on the agent? > On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > <https://reviews.apache.org/r/55887/diff/3/?file=1627222#file1627222line1722> > > > > Why not TASK_ERROR? AFAICT, `TASK_ERROR` is only generated from the master and never from the agents; agents only generate `TASK_FAILED` on a failure. So, I left this status update that the agent generates as `TASK_FAILED`. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review165999 ----------------------------------------------------------- On Feb. 8, 2017, 3:53 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55887/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 3:53 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu. > > > Bugs: MESOS-6953 > https://issues.apache.org/jira/browse/MESOS-6953 > > > Repository: mesos > > > Description > ------- > > Added support for action `run_tasks` on the agent's flag `acl`. Based on > the ACL configured for `run_tasks`, a task to be launched on the agent > will be (dis)allowed to launch on the agent. > If a task or task group cannot be launched due to failed authorization, > a `TASK_FAILED` Status Update shall be sent with a reason code of > `REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as > applicable. > Note that in case of a task group, all tasks fail if any of the tasks > within the task group encounter the authorization error. > > > Diffs > ----- > > src/slave/slave.hpp 5049eb783b8ad7b9599f20c3701f7d3d654b4491 > src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8 > > Diff: https://reviews.apache.org/r/55887/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
