> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > <https://reviews.apache.org/r/55887/diff/3/?file=1627222#file1627222line1722> > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` is only generated from the master and never from the > agents; agents only generate `TASK_FAILED` on a failure. So, I left this > status update that the agent generates as `TASK_FAILED`. > > Jiang Yan Xu wrote: > I don't think there's such a distinction. `TASK_ERROR` indicates there's > some error with the task that there's no point in retrying. We didn't have a > case where the master validation/authorization couldn't capture the error but > now we do. In other existing TASK_ERROR cases that come from the master, the > task shouldn't be retried on any agents. In this case, it's still true that > if we resend the same task to the same agent it's going to fail again. The > difference is then the scheduler will have to look at the source of the > status update to distinguish. Nevertheless, authorization failure fits the > definition of TASK_ERROR and let's use it instead.
Sure thing. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review165999 ----------------------------------------------------------- On Feb. 28, 2017, 1:17 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55887/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 1:17 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu. > > > Bugs: MESOS-6953 > https://issues.apache.org/jira/browse/MESOS-6953 > > > Repository: mesos > > > Description > ------- > > Added support for action `run_tasks` on the agent's flag `acl`. Based on > the ACL configured for `run_tasks`, a task to be launched on the agent > can be (dis)allowed to launch on the agent. > If a task or task group cannot be launched due to failed authorization, > a `TASK_ERROR` Status Update shall be sent with a reason code of > `REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as > applicable. > Note that in case of a task group, all tasks fail if any of the tasks > within the task group encounter the authorization error. > > > Diffs > ----- > > src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 > src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a > src/tests/master_slave_reconciliation_tests.cpp > 1c7a3d686e2f924ad14c75fcab2ccafaab6d7b81 > src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 > src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf > src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705 > > Diff: https://reviews.apache.org/r/55887/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
