----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56837/#review166227 -----------------------------------------------------------
Hm.. I think you need to update the `updateSlave` function as well. Otherwise, when an agent is upgraded, the capabilities will not be updated in the allocator. src/master/allocator/mesos/hierarchical.hpp (line 379) <https://reviews.apache.org/r/56837/#comment238120> No need for the comment. src/master/master.cpp (line 8101) <https://reviews.apache.org/r/56837/#comment238119> how about: ``` google::protobuf::convert(slave->capabilities.toRepeatedPtrField()), ``` - Benjamin Mahler On Feb. 20, 2017, 4:46 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56837/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 4:46 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and > Michael Park. > > > Bugs: MESOS-6940 > https://issues.apache.org/jira/browse/MESOS-6940 > > > Repository: mesos > > > Description > ------- > > Allocator should be aware of slave capabilities in order to make > correct/smarter decisions on resource allocations. The interface > `addSlave` is augmented to pass in agent capabilities and we store > them in HierarchicalAllocatorProcess. Tests are updated accordingly. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 23413d1f9d76009c999b35d2bc98afc52c136404 > src/master/allocator/mesos/allocator.hpp > 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215 > src/master/allocator/mesos/hierarchical.hpp > d33306745a7287b750cb4a5242c7527369d58d65 > src/master/allocator/mesos/hierarchical.cpp > eeb44fe89d4bfd26900b11833c1182157e5c7e5c > src/master/master.cpp 0f9fc39c1bd2af032f908d0263ed6a592ef1771c > src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714 > src/tests/api_tests.cpp 7715da9072e7be81eb19e742857ff7ab3fd60ea5 > src/tests/hierarchical_allocator_tests.cpp > 5441fa9d1fad1ca7819038db49c6d88e40571e4a > src/tests/master_allocator_tests.cpp > 25c67d32eec5fede78eb9fcbc1009eeff7da0dad > src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5 > src/tests/persistent_volume_endpoints_tests.cpp > ec8df33a3f0d4ad790d5cc753e1691c5517c39c0 > src/tests/reservation_endpoints_tests.cpp > 7432d752120b43560aa96cad8bf3981ee8102e67 > src/tests/reservation_tests.cpp 309ce8b9acc9131110198c14c655427d7fe9d603 > src/tests/slave_recovery_tests.cpp 0e295915fea0a7314e173857249bd8726eeccd76 > > Diff: https://reviews.apache.org/r/56837/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
