----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ -----------------------------------------------------------
Review request for mesos and Michael Park. Repository: mesos Description ------- The quota'd resources for a nested role are "included" within the quota'd resources for that role's parent. Hence, the quota of a node must always be greater than or equal to the sum of the quota'd resources of that role's children. When creating and removing quota, we must ensure that this invariant is not violated. When computing the cluster capacity heuristic, we must ensure that we do not "double-count" quota'd resources: e.g., if the cluster has a total capacity of 100 cpus, role "x" has a quota guarantee of 60 CPUs, and role "x/y" has a quota guarantee of 55 CPUs, this does NOT violate the cluster capacity heuristic. Diffs ----- src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630 src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a Diff: https://reviews.apache.org/r/57167/diff/ Testing ------- `make check` Thanks, Neil Conway
