> On March 9, 2017, 9:39 p.m., Michael Park wrote: > > src/master/quota_handler.cpp > > Lines 469-487 (original), 583-605 (patched) > > <https://reviews.apache.org/r/57167/diff/2/?file=1660312#file1660312line584> > > > > I think we should be able to use `strings::tokenize(request.url.path, > > "/", 3)` here. > > Neil Conway wrote: > Personally I think the current coding is clearer, albeit more verbose. > Also `strings::tokenize` skips empty tokens (e.g., `//`), which probably > isn't the behavior we want here.
You can use strings::split if no empty token skipping is desired. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/#review168525 ----------------------------------------------------------- On March 10, 2017, 5:04 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57167/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 5:04 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > The quota'd resources for a nested role are "included" within the > quota'd resources for that role's parent. Hence, the quota of a node > must always be greater than or equal to the sum of the quota'd resources > of that role's children. > > When creating and removing quota, we must ensure that this invariant is > not violated. > > When computing the cluster capacity heuristic, we must ensure that we do > not "double-count" quota'd resources: e.g., if the cluster has a total > capacity of 100 CPUs, role "x" has a quota guarantee of 80 CPUs, and > role "x/y" has a quota guarantee of 40 CPUs, this does NOT violate the > cluster capacity heuristic. > > > Diffs > ----- > > src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 > src/tests/hierarchical_allocator_tests.cpp > dce619ec49db480685deb1bf8f7faeebe02e25b5 > src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 > > > Diff: https://reviews.apache.org/r/57167/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
