> On March 9, 2017, 2:20 p.m., Alexander Rojas wrote: > > I just wonder if there are any rules for when to use the namespace or when > > it can be omit it?
I don't know if we have any rules for that. It just irked me that the usage of namespaces in this file wasn't consistent - neither with `master/http.cpp` nor within itself. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57341/#review168448 ----------------------------------------------------------- On March 8, 2017, 11:11 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57341/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 11:11 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > Followed the convention in 'master/http.cpp' and explicitly used the > 'mesos::' prefix. > > > Diffs > ----- > > src/slave/http.cpp bc8209cb81194ebc8b604c9ba0d4a9e176cff2f6 > > > Diff: https://reviews.apache.org/r/57341/diff/2/ > > > Testing > ------- > > > Thanks, > > Gastón Kleiman > >