----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168515 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 2386 (patched) <https://reviews.apache.org/r/57384/#comment240755> s/cleanupArtifacts/remove/ It's not just about artifacts. This interface will also remove the metadata associated with the container. src/slave/containerizer/mesos/containerizer.cpp Lines 2391 (patched) <https://reviews.apache.org/r/57384/#comment240754> Instead of CHECK, I would return a Failure here. We should avoid CHECK if possible. src/slave/containerizer/mesos/containerizer.cpp Lines 2395-2396 (patched) <https://reviews.apache.org/r/57384/#comment240762> Error message here should not include 'containerId' because that's the responsibility of the caller. Ditto elsewhere. src/slave/containerizer/mesos/containerizer.cpp Lines 2401-2406 (patched) <https://reviews.apache.org/r/57384/#comment240759> I would return an Error here instead. The reason is because the caller expects the sandbox associated with the nested container is gone if this call returns a success. The code here will break this invariant. I would also adjust the comments here. src/slave/containerizer/mesos/containerizer.cpp Lines 2413 (patched) <https://reviews.apache.org/r/57384/#comment240760> I'll kill this line src/slave/containerizer/mesos/containerizer.cpp Lines 2426 (patched) <https://reviews.apache.org/r/57384/#comment240761> I'll kill this line src/tests/containerizer/nested_mesos_containerizer_tests.cpp Lines 1990 (patched) <https://reviews.apache.org/r/57384/#comment240763> I'll adjust the name of this test according to my comments above. src/tests/containerizer/nested_mesos_containerizer_tests.cpp Lines 2157-2159 (patched) <https://reviews.apache.org/r/57384/#comment240764> you may want to adjust here. - Jie Yu On March 9, 2017, 1:46 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57384/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 1:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod > Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > This new method cleans up the sandbox and runtime directories of a > terminated nested container. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp > f65a9b9761fc254bd0778bf13aac9b256497b22f > src/slave/containerizer/mesos/containerizer.hpp > 09f94ccb3224c14a9324961b789455b119ec2257 > src/slave/containerizer/mesos/containerizer.cpp > b001d0265ec73822193eaac74c631930acce90c0 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > ea01fe55a28d17105157004d8cf0976202a49b7c > > > Diff: https://reviews.apache.org/r/57384/diff/3/ > > > Testing > ------- > > Added a test and verified that it works on Linux. > > > Thanks, > > Gastón Kleiman > >
