> On March 8, 2017, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 158 (patched) > > <https://reviews.apache.org/r/57384/diff/1/?file=1658465#file1658465line158> > > > > can we call it 'delete'? This is more consistent with > > `DeleteNestedContainer` call? > > Gastón Kleiman wrote: > What do you think about `deleteArtifacts`? `delete` is a reserved > keyword, I might be able to name a method `delete`, but it is not very > explicit... and it confuses vim ;-). > > Vinod Kone wrote: > Yea, I don't like `cleanupArtifacts` either because it's not clear this > is called by `DeleteNestedContainer`. We have a similar issue with > `KillNestedContainer` where it calls `Containerizer::destroy()`. Sigh. > > What about `RemoveNestedContainer` and `Containerizer::remove()`? > `remove` and `delete` are synonyms afterall and docker uses it as well. Looks > like k8s uses `delete`. > > Vinod Kone wrote: > Also this needs to be moved up next to `destroy()` > > Vinod Kone wrote: > Another option is `GCNestedContainer` and `Containerizer::gc()` > > Vinod Kone wrote: > Looks like `delete` is better than `remove` because the former connotes > permanence. > http://english.stackexchange.com/questions/52508/difference-between-delete-and-remove
We chatted about this and decided to go with `remove` and `RemoveNestedContainer`. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168226 ----------------------------------------------------------- On March 13, 2017, 12:32 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57384/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 12:32 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod > Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > This new method removes the sandbox and runtime directories of a > terminated nested container. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp > f65a9b9761fc254bd0778bf13aac9b256497b22f > src/slave/containerizer/mesos/containerizer.hpp > 09f94ccb3224c14a9324961b789455b119ec2257 > src/slave/containerizer/mesos/containerizer.cpp > 7676a4d8a35f2239c7373b0a9e76fa343b322f62 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > ea01fe55a28d17105157004d8cf0976202a49b7c > > > Diff: https://reviews.apache.org/r/57384/diff/5/ > > > Testing > ------- > > Added a test and verified that it works on Linux. > > > Thanks, > > Gastón Kleiman > >
