----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57615/#review169183 -----------------------------------------------------------
Patch looks great! Reviews applied: [56474, 56476, 56475, 57663, 57664, 57665, 57666, 57670, 57671, 57667, 57615] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 16, 2017, 3:42 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57615/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 3:42 p.m.) > > > Review request for mesos, Anand Mazumdar, Jan Schlicht, and Vinod Kone. > > > Bugs: MESOS-6304 > https://issues.apache.org/jira/browse/MESOS-6304 > > > Repository: mesos > > > Description > ------- > > This patch adds support for authentication tokens to the > V1 default executor library. The tokens are loaded from a > pre-determined environment variable, if present. > > > Diffs > ----- > > src/executor/executor.cpp 35378ec4b55ce0427e95f6b868baa6233c9068cd > > > Diff: https://reviews.apache.org/r/57615/diff/2/ > > > Testing > ------- > > make check > > Once MESOS-6999 is resolved, additional tests must be implemented to verify > that executor authentication is performed correctly. > > > Thanks, > > Greg Mann > >
