----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review170237 -----------------------------------------------------------
I think we should strip everything out of this commit except the parsing of the plugins array from the TOML file (which isn't in this commit at all yet). We should move that functionality out of settings.py and into here. - Kevin Klues On March 27, 2017, noon, Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57952/ > ----------------------------------------------------------- > > (Updated March 27, 2017, noon) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7269 > https://issues.apache.org/jira/browse/MESOS-7269 > > > Repository: mesos > > > Description > ------- > > Used to show and validate the configuration file given by the user. > > > Diffs > ----- > > src/cli_new/bin/settings.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/57952/diff/1/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
