> On April 5, 2017, 5:10 p.m., Kevin Klues wrote: > > src/cli_new/lib/mesos/plugins/config/main.py > > Lines 96-102 (patched) > > <https://reviews.apache.org/r/57952/diff/2/?file=1682664#file1682664line96> > > > > I would actually leverage the Table abstraction to print th eplugins > > here. I think this might be a discarded RR from me that should probably be > > revived for this.
Armand, in case you want to revive the Table abstraction, here it is: https://reviews.apache.org/r/52948/ - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171180 ----------------------------------------------------------- On March 27, 2017, 5 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57952/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 5 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7269 > https://issues.apache.org/jira/browse/MESOS-7269 > > > Repository: mesos > > > Description > ------- > > Used to load and show the plugins available for the user. > > > Diffs > ----- > > src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d > src/cli_new/bin/settings.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/57952/diff/2/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
