----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57976/ -----------------------------------------------------------
(Updated March 28, 2017, 11:28 p.m.) Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. Changes ------- Update test results. Repository: mesos Description ------- This commit reverses the file split done in e821978. Since `launchTaskPosix` and `launchTaskWindows` were reconciled using `Subprocess`, the files were pulled back into just `launcher/executor.cpp` with `launchTaskSubprocess`. Diffs ----- src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e src/launcher/CMakeLists.txt f63f544f92924b92ef41382c40acabef59a56d8b src/launcher/executor.hpp c7c134aed26d2116295d66100b3d6efaf610736c src/launcher/executor.cpp a4bac9d932b6574eb2e1b4a27aa44eaaca6aaa62 src/launcher/posix/executor.hpp 2dd9766aa5b6e0550269ccaa79209d0a483fee76 src/launcher/posix/executor.cpp 7c4ef10390e7ecfe63e2fd0c813f91c896fc7a8d Diff: https://reviews.apache.org/r/57976/diff/1/ Testing (updated) ------- # CentOS 7: ## `make check` ``` [----------] Global test environment tear-down [==========] 1534 tests from 173 test cases ran. (434228 ms total) [ PASSED ] 1533 tests. [ FAILED ] 1 test, listed below: [ FAILED ] LdcacheTest.Parse ``` Assuming that `LdcacheTest.Parse` is unrelated. # Windows 10: ## `./3rdparty/stout/tests/Debug/stout-tests.exe` ``` [==========] 230 tests from 39 test cases ran. (4361 ms total) [ PASSED ] 228 tests. [ FAILED ] 2 tests, listed below: [ FAILED ] Base64Test.EncodeURLSafe [ FAILED ] Base64Test.DecodeURLSafe ``` These are [known failures](https://issues.apache.org/jira/browse/MESOS-7236). ## `./3rdparty/libprocess/src/tests/Debug/libprocess-tests.exe` ``` [----------] Global test environment tear-down [==========] 116 tests from 26 test cases ran. (10006 ms total) [ PASSED ] 116 tests. ``` ## `.\src\mesos-tests.exe --gtest_filter="MesosContainerizer/*"` ``` [----------] 7 tests from MesosContainerizer/DefaultExecutorTest (110253 ms total) [----------] Global test environment tear-down [==========] 7 tests from 1 test case ran. (111066 ms total) [ PASSED ] 7 tests. ``` ## Entire `.\src\mesos-tests.exe` ``` [----------] Global test environment tear-down [==========] 558 tests from 57 test cases ran. (66481401 ms total) [ PASSED ] 543 tests. [ FAILED ] 15 tests, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckStatusChange [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout [ FAILED ] CommandExecutorCheckTest.CommandCheckAndHealthCheckNoShadowing [ FAILED ] HealthCheckTest.HealthyTask [ FAILED ] HealthCheckTest.HealthyTaskNonShell [ FAILED ] HealthCheckTest.HealthStatusChange [ FAILED ] HealthCheckTest.ConsecutiveFailures [ FAILED ] HealthCheckTest.EnvironmentSetup [ FAILED ] HealthCheckTest.GracePeriod [ FAILED ] HealthCheckTest.CheckCommandTimeout [ FAILED ] HealthCheckTest.HealthyToUnhealthyTransitionWithinGracePeriod [ FAILED ] HealthCheckTest.HealthyTaskViaTCP [ FAILED ] CombinedAuthenticatorTest.MultipleAuthenticators [ FAILED ] SlaveTest.StatisticsEndpointRunningExecutor [ FAILED ] CopyFetcherPluginTest.FetchExistingFile ``` The `FetchExistingFile` is a [known failure](https://issues.apache.org/jira/browse/MESOS-7311). The `CommandExecutorCheckTest` failures are new, and I've traced them to the difference between: ``` .\mesos-containerizer.exe launch --help=false --launch_info={"command":{"shell":true,"value":"ping 127.0.0.1 -n 10000"}} ``` and ``` .\mesos-containerizer.exe launch --help=false --launch_info="{\"command\":{\"shell\":true,\"value\":\"ping 127.0.0.1 -n 10000\"}}" ``` so I need to introduce some quoting to `launchTaskSubprocess`. Thanks, Andrew Schwartzmeyer
