> On March 29, 2017, 2:40 p.m., Joseph Wu wrote: > > src/launcher/executor.hpp > > Lines 21-27 (original), 21 (patched) > > <https://reviews.apache.org/r/57975/diff/1/?file=1677274#file1677274line21> > > > > There's going to be a bunch of code movement... > > > > But now that the `launcher/windows/executor.*` are disappearing, all > > the common code should be moved into this file. And a corresponding .cpp > > file.
And now I see the next review :D https://reviews.apache.org/r/57976 Consider squashing the two together. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57975/#review170485 ----------------------------------------------------------- On March 27, 2017, 3:39 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57975/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 3:39 p.m.) > > > Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Repository: mesos > > > Description > ------- > > By encapsulating the job object logic inside the Windows libprocess > actor, we're able to reuse `subprocess` for launching tasks on Windows. > This allows us to remove the entirety of `launchTaskWindows` and instead > reuse `launchTaskPosix`, which just uses `subprocess`. This also fixed > the `CommitSuicideOnTaskFailure` test, which is now enabled. > > > Diffs > ----- > > src/launcher/CMakeLists.txt f63f544f92924b92ef41382c40acabef59a56d8b > src/launcher/executor.hpp c7c134aed26d2116295d66100b3d6efaf610736c > src/launcher/executor.cpp a4bac9d932b6574eb2e1b4a27aa44eaaca6aaa62 > src/launcher/posix/executor.hpp 2dd9766aa5b6e0550269ccaa79209d0a483fee76 > src/launcher/posix/executor.cpp 7c4ef10390e7ecfe63e2fd0c813f91c896fc7a8d > src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0 > src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000 > src/tests/default_executor_tests.cpp > 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f > > > Diff: https://reviews.apache.org/r/57975/diff/1/ > > > Testing > ------- > > Testing done at end of chain. > > > Thanks, > > Andrew Schwartzmeyer > >