----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58059/#review170523 -----------------------------------------------------------
Patch looks great! Reviews applied: [58056, 58057, 58058, 58059] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 29, 2017, 6:20 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58059/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 6:20 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-6919 > https://issues.apache.org/jira/browse/MESOS-6919 > > > Repository: mesos > > > Description > ------- > > HttpProxy actors are spawned to manage incoming HTTP connections. > These actors are themselves garbage collected, meaning it is unsafe > to refer to an HttpProxy by pointer (which is what is currently done). > > During libprocess finalization, it is possible for an incoming > connection to spawn an HttpProxy, whose pointer is then deleted by > finalization. This leads to a potential segfault when cleaning up > the incoming connection, as the SocketManager will dereference > any related HttpProxy actors by pointer. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > f6ee24e2db43d63d91222549efee85421bbf9bf3 > > > Diff: https://reviews.apache.org/r/58059/diff/1/ > > > Testing > ------- > > With the additional test here: https://reviews.apache.org/r/58056/ > > make check > > 3rdparty/libprocess/src/tests/libprocess-tests > --gtest_filter="*RapidReconnect*" --gtest_repeat=1000 > > > Thanks, > > Joseph Wu > >
