----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57998/#review171284 -----------------------------------------------------------
Fix it, then Ship it! src/tests/resources_utils.cpp Lines 29 (patched) <https://reviews.apache.org/r/57998/#comment244175> why this change? - Jie Yu On April 5, 2017, 1:56 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57998/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 1:56 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > This patch adds an optional resource provider id to resources. In > future changes we will introduce abstract providers of resources. > While currently agents are implicit resource providers, later on an > agent might use multiple resource providers. By having a provider id > in the resource we can unambigously detect which provider contributed > which resource. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d > src/tests/resources_utils.cpp 2cef55f7312d671307e097c2c4960c8dcf45c1ff > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/57998/diff/4/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > >
