> On April 7, 2017, 1:58 a.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Lines 1081 (patched) > > <https://reviews.apache.org/r/58196/diff/1/?file=1684610#file1684610line1081> > > > > Does this work even when executor is running with its own file system? > > Alexander Rukletsov wrote: > This is a good question. My understanding is that an executor always have > access to `launcherDir` because it's necessary for `mesos-containerizer` > command, which we, e.g., put into `pre_exec_commands`. However, this might > not be the case for the default executor, because launch is delegated to the > agent in this case. @Jie, @Gilbert, any comments? > > Jie Yu wrote: > Both default executor and command executor can see agent's filesystem. Is > the expectation here that the checker will only be used by these two > executors? > > Vinod Kone wrote: > Yea checker is only used by default and command executors. So I think we > are ok here.
We might add support for docker executor in the future. I'll add a note here. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58196/#review171307 ----------------------------------------------------------- On April 7, 2017, 3:25 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58196/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 3:25 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7275 > https://issues.apache.org/jira/browse/MESOS-7275 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 > src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 > src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 > src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e > src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 > > > Diff: https://reviews.apache.org/r/58196/diff/2/ > > > Testing > ------- > > make check on Mac OS 10.11.6 and various linux variants. > > > Thanks, > > Alexander Rukletsov > >
