----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/#review172260 -----------------------------------------------------------
I'd like to understand the tests that you ran before you posted the review. What, specifically, did you test on to insure that nothing was broken by this change? - Jeff Coffler On April 14, 2017, 2:03 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58447/ > ----------------------------------------------------------- > > (Updated April 14, 2017, 2:03 a.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Repository: mesos > > > Description > ------- > > This commit removes duplicate code from `3rdparty/CMakeLists.txt`, > and consolidates platform-specific versions into `Versions.cmake`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > c60652688a23f8628f133b7890ff39e38fc8ae94 > 3rdparty/cmake/Versions.cmake 912726351ff744dd839b8d1c8d64dcc373d879be > cmake/CompilationConfigure.cmake 1c5466960f5ac73b8fc81edf7950cc68ed744301 > > > Diff: https://reviews.apache.org/r/58447/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
