----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review173524 -----------------------------------------------------------
Patch looks great! Reviews applied: [58753, 58725, 58778] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 1, 2017, 7:24 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58778/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 7:24 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7431 > https://issues.apache.org/jira/browse/MESOS-7431 > > > Repository: mesos > > > Description > ------- > > Certain registries, such as GCE registry, reply 403 instead of 401 for > unauthorized requests. When fetching image manifests and blobs, instead > of sending out unauthorized requests first and waiting for a possible > 401, we should always look up the docker config and send requests with > basic authorization when possible. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 > > > Diff: https://reviews.apache.org/r/58778/diff/1/ > > > Testing > ------- > > sudo make check (covers all supported public registries) > Manually tested on the following private registries: > 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1) > 2. Amazon ECR > 3. Google GCR > > > Thanks, > > Chun-Hung Hsiao > >
