----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58778/#review174975 -----------------------------------------------------------
This patch looks good. Need to take aother look at the `fetchBlob()` logic once I wake up. Will make another pass. Thanks! src/uri/fetchers/docker.cpp Lines 653 (patched) <https://reviews.apache.org/r/58778/#comment248275> s/furute/futrue/g src/uri/fetchers/docker.cpp Lines 748 (patched) <https://reviews.apache.org/r/58778/#comment248284> Seems like a pre-request of calling `getAuthHeader()` is calling `getAuthHeaderBasic()` first. I am fine with this change (a hard dependency), but should we rename this variable (as well as the one in `_fetch()` to be `basicAuthHeaders`? It might be less confusing since we have another `getAuthHeaders()` helper. - Gilbert Song On May 12, 2017, 5:45 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58778/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 5:45 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7431 > https://issues.apache.org/jira/browse/MESOS-7431 > > > Repository: mesos > > > Description > ------- > > Certain registries, such as GCE registry, reply 403 instead of 401 for > unauthorized requests. When fetching image manifests and blobs, instead > of sending out unauthorized requests first and waiting for a possible > 401, we should always look up the docker config and send requests with > basic authorization when possible. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp dbfc1b2f2918ccaf90fa31496a0792f585489397 > > > Diff: https://reviews.apache.org/r/58778/diff/3/ > > > Testing > ------- > > sudo make check (covers all supported public registries) > Manually tested on the following private registries: > 1. Local registry (2.0.1, 2.1.1, 2.2.1, ..., 2.6.1) > 2. Amazon ECR > 3. Google GCR > 4. JFrog SaaS > 5. Local Nexus registry 3.3.1 > > > Thanks, > > Chun-Hung Hsiao > >
