----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ -----------------------------------------------------------
(Updated May 5, 2017, 9:16 p.m.) Review request for mesos, haosdent huang and Vinod Kone. Changes ------- OK, I believe I have addressed all issues here, I also simplified the code a bit to use releases.yml as the source of versions to generate docs for, rather than the git tags themselves, and made the "docs:" key optional in that file. It only needs to be present if the given version should not have documentation generated for it, in which case it is set as "docs: false". This also removes the need for the version check within the Rakefile itself. Please let me know if any additional changes are needed. Bugs: MESOS-3011 https://issues.apache.org/jira/browse/MESOS-3011 Repository: mesos Description ------- Support for multiple versions of docs. Diffs (updated) ----- site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac site/source/assets/js/versions.js PRE-CREATION site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 site/source/layouts/documentation.erb a91f916a5fb7348b2702c272e7a2059bdf628c66 Diff: https://reviews.apache.org/r/52064/diff/3/ Changes: https://reviews.apache.org/r/52064/diff/2-3/ Testing ------- Testing was done manually to verify that the documentation was built for each version of Mesos that is supported (some older versions do not have compatible documentation). Thanks, Tim Anderegg