> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/Rakefile > > Lines 122 (patched) > > <https://reviews.apache.org/r/52064/diff/2/?file=1582226#file1582226line154> > > > > Replace all `\/latest\/` looks a bit dangerous. Do you have an example > > for this? > > Tim Anderegg wrote: > I ran the code across the documentation from a number of versions, and > determined that the only place the \/latest\/ string occurred was in URL's > that should be replaced, e.g. here: > https://raw.githubusercontent.com/apache/mesos/0.22.1/docs/home.md
Well, you were right :) There were a few edge cases where this was too gready, so I updated the regex to be more restrictive. > On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/data/releases.yml > > Lines 108 (patched) > > <https://reviews.apache.org/r/52064/diff/2/?file=1582229#file1582229line108> > > > > I think we only need to keep the version `>=0.26.0`. This reduce the > > website generation time as well. > > Tim Anderegg wrote: > I'm happy to remove the older versions if desired. I went with >=0.22.1, since that is the oldest tag on the apache/mesos github repo. If we should just go with 0.26.0, I can do that instead. > On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/source/assets/css/main.css > > Lines 39-41 (patched) > > <https://reviews.apache.org/r/52064/diff/2/?file=1582230#file1582230line39> > > > > Could not find the differece for this css change. Is it necessary? > > Tim Anderegg wrote: > This was to better space the <option> tag used to select the proper > version that is part of the breadcrumb. Without it, the alignement is off. Actually, you were right this was not needed, sorry! > On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/source/layouts/gettingstarted.erb > > Lines 1 (patched) > > <https://reviews.apache.org/r/52064/diff/2/?file=1582234#file1582234line1> > > > > This layout file is unused, right? > > Tim Anderegg wrote: > It is unused in recent versions, but was used in older versions. Since > the most recent "layouts" folder is used for rendering all versions of the > documentation after the generation process, it must contain all past layouts > or else the renderer will produce an error. Now that we are only doing versions >= 0.22.1, this is no longer needed. - Tim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review160091 ----------------------------------------------------------- On May 5, 2017, 9:16 p.m., Tim Anderegg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52064/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 9:16 p.m.) > > > Review request for mesos, haosdent huang and Vinod Kone. > > > Bugs: MESOS-3011 > https://issues.apache.org/jira/browse/MESOS-3011 > > > Repository: mesos > > > Description > ------- > > Support for multiple versions of docs. > > > Diffs > ----- > > site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807 > site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf > site/Rakefile 01356891c29f9e69fa0f7813cf87e7662eda400b > site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 > site/config.rb 9e6738fccc48365e16221188269c1ed40772eca7 > site/data/releases.yml 8bdc3ff11a821f5e1be04ac871c05b16403a82ac > site/source/assets/js/versions.js PRE-CREATION > site/source/layouts/basic.erb 3bf1f55d7d8feafd3caaa7902755404f7e45bae6 > site/source/layouts/documentation.erb > a91f916a5fb7348b2702c272e7a2059bdf628c66 > > > Diff: https://reviews.apache.org/r/52064/diff/3/ > > > Testing > ------- > > Testing was done manually to verify that the documentation was built for each > version of Mesos that is supported (some older versions do not have > compatible documentation). > > > Thanks, > > Tim Anderegg > >
