----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review174240 -----------------------------------------------------------
Fix it, then Ship it! src/secret/resolver.cpp Lines 40 (patched) <https://reviews.apache.org/r/58760/#comment247355> The comment about default resolver behavior in the previous review should be here instead. src/secret/resolver.cpp Lines 72 (patched) <https://reviews.apache.org/r/58760/#comment247356> new line above. - Vinod Kone On May 8, 2017, 10:19 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58760/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 10:19 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Added default secret resolver module. > > > Diffs > ----- > > src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/secret/resolver.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/58760/diff/6/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
