----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review175323 -----------------------------------------------------------
Ship it! src/secret/resolver.cpp Lines 40 (patched) <https://reviews.apache.org/r/58760/#comment248777> C style comments? - Vinod Kone On May 16, 2017, 7:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58760/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 7:22 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Added default secret resolver module. > > > Diffs > ----- > > src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/secret/resolver.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/58760/diff/9/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
