----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174270 -----------------------------------------------------------
As we discussed offline, let's not mess the URI struct. Instead, passing the secret to the fetcher using an function parameter in the `fetch` method. This will be useful in the future also because fetcher other URIs might need secret as well. - Jie Yu On May 4, 2017, 11:22 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59015/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 11:22 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing docker config to URIs. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > src/uri/schemes/docker.hpp 527c7e4ba6f1b505543655cca870e39b93a5266e > > > Diff: https://reviews.apache.org/r/59015/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
