----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review175742 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 87 (patched) <https://reviews.apache.org/r/59015/#comment249100> I think we don't need a default here. src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp Lines 101 (patched) <https://reviews.apache.org/r/59015/#comment249101> Ditto. - Chun-Hung Hsiao On May 22, 2017, 5:59 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59015/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 5:59 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing docker config depended methods. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > > > Diff: https://reviews.apache.org/r/59015/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
