> On May 8, 2017, 8:05 p.m., Vinod Kone wrote: > > src/slave/main.cpp > > Line 450 (original), 463 (patched) > > <https://reviews.apache.org/r/58999/diff/4/?file=1710998#file1710998line463> > > > > If the pointer to resolver is only passed to the containerizer, how > > will the agent get access to it to resolve executor auth token?
We'll be modifying the `executorEnvironment` signature to return `Try<Environment>` instead of `map<string, string>` so that all env vars can be resolved in the containerizer itself (via env isolator). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/#review174248 ----------------------------------------------------------- On May 9, 2017, 2:11 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58999/ > ----------------------------------------------------------- > > (Updated May 9, 2017, 2:11 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated Containerizer to accept SecretResolver. > > > Diffs > ----- > > src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 > src/slave/containerizer/containerizer.hpp > 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 > src/slave/containerizer/containerizer.cpp > 9024371b6c4228f0903cfeef3bbec736e1a425f8 > src/slave/containerizer/mesos/containerizer.hpp > 29a99f33e646593127b9dc126f398f7bca88e21d > src/slave/containerizer/mesos/containerizer.cpp > 58ab74571fb14c6dbb1907151dc421f93e324bb5 > src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd > src/slave/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 > src/slave/main.cpp 507d59996a90f51c7cd1e0f836a34c2e9c484791 > src/tests/containerizer/docker_volume_isolator_tests.cpp > b47a6b5081a63ac474ac4634701b1a572eb58137 > src/tests/containerizer/mesos_containerizer_tests.cpp > 13e0f7e603a3ffdd0965b253d7abfe6a069cd2b4 > > > Diff: https://reviews.apache.org/r/58999/diff/5/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
