----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/#review174918 -----------------------------------------------------------
src/slave/flags.cpp Lines 961-964 (patched) <https://reviews.apache.org/r/58999/#comment248230> Should we consider make the `default secret resolver` as the default value for this flag? So that we can get rid of the logic in `SecretResolver::create()`. src/slave/flags.cpp Lines 963 (patched) <https://reviews.apache.org/r/58999/#comment248188> s/secret resolve module/secret resolver module/g ? - Gilbert Song On May 12, 2017, 10:52 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58999/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 10:52 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Updated Containerizer to accept SecretResolver. > > > Diffs > ----- > > src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3 > src/slave/containerizer/containerizer.hpp > 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 > src/slave/containerizer/containerizer.cpp > 9024371b6c4228f0903cfeef3bbec736e1a425f8 > src/slave/containerizer/mesos/containerizer.hpp > 04ab997454534b8e5e821b53b83e166e5018e11c > src/slave/containerizer/mesos/containerizer.cpp > 97837c83cc223950750e4cd088f4da067023c96c > src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd > src/slave/flags.cpp bc63a6a4cb6115b4b4d592e67e34045f52b50d4c > src/slave/main.cpp 507d59996a90f51c7cd1e0f836a34c2e9c484791 > > > Diff: https://reviews.apache.org/r/58999/diff/6/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
