-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59017/#review174398
-----------------------------------------------------------




include/mesos/docker/spec.hpp
Line 76 (original), 76 (patched)
<https://reviews.apache.org/r/59017/#comment247531>

    s/as a/from a/



include/mesos/docker/spec.hpp
Lines 82 (patched)
<https://reviews.apache.org/r/59017/#comment247532>

    s/as a/from a/



include/mesos/docker/spec.hpp
Lines 83 (patched)
<https://reviews.apache.org/r/59017/#comment247533>

    no unit test for this?


- Vinod Kone


On May 4, 2017, 11:22 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59017/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till 
> Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for docker spec helper 'parseAuthConfig()'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 
>   src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17 
> 
> 
> Diff: https://reviews.apache.org/r/59017/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to