> On May 9, 2017, 4:25 p.m., Vinod Kone wrote: > > include/mesos/docker/spec.hpp > > Lines 83 (patched) > > <https://reviews.apache.org/r/59017/diff/1/?file=1709140#file1709140line83> > > > > no unit test for this?
This helper was tested in unit test when the parameter is a JSON object. Thought no duplicate unit test needed for the `string` parameter since they are the same implementation. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59017/#review174398 ----------------------------------------------------------- On May 4, 2017, 4:22 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59017/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 4:22 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Added support for docker spec helper 'parseAuthConfig()'. > > > Diffs > ----- > > include/mesos/docker/spec.hpp b90f731ef07c22259715543526eaf25cb94eab03 > src/docker/spec.cpp 6b5588e534215451593cc20011847c3abbab9b17 > > > Diff: https://reviews.apache.org/r/59017/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
