> On May 5, 2017, 2:42 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 693 (patched) > > <https://reviews.apache.org/r/59018/diff/1/?file=1709142#file1709142line693> > > > > Is it a good idea to overload the "password" field in a URI as a docker > > config carrier? > > Chun-Hung Hsiao wrote: > If we decide to stick with this implementation, maybe we should document > it in `uri.proto`.
By changing the URI fetcher interface. We are not using the uri to pass docker config now. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174075 ----------------------------------------------------------- On May 4, 2017, 4:22 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59018/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 4:22 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Supported Image::Secret in docker URI fetcher plugin. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 > > > Diff: https://reviews.apache.org/r/59018/diff/1/ > > > Testing > ------- > > make check > > Manually tested using mesos-execute with task group. Verified that pulling > separate private image from different registries using different image > secrets works correctly. > > > Thanks, > > Gilbert Song > >
