----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174511 -----------------------------------------------------------
Please rebase to the latest master and resolve the conflicts. src/uri/fetchers/docker.cpp Lines 328 (patched) <https://reviews.apache.org/r/59018/#comment247666> Why are we using `secretValue` instead of `config` as in other places? Also, it seems to me that `uri` and `secretValue` are coupled, so how about putting them side by side in the parameter list? Same for the following code. src/uri/fetchers/docker.cpp Lines 525 (patched) <https://reviews.apache.org/r/59018/#comment247681> It's unfortunate that we still need `secretValue` for fetching blobs after we have `authHeaders` but I cannot think of a way to make it cleaner, so just leave a note here. - Chun-Hung Hsiao On May 10, 2017, 12:48 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59018/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 12:48 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Supported Image::Secret in docker URI fetcher plugin. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 > > > Diff: https://reviews.apache.org/r/59018/diff/2/ > > > Testing > ------- > > make check > > Manually tested using mesos-execute with task group. Verified that pulling > separate private image from different registries using different image > secrets works correctly. > > > Thanks, > > Gilbert Song > >
