----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56681/ -----------------------------------------------------------
(Updated May 16, 2017, 11:19 p.m.) Review request for mesos, haosdent huang and Jiang Yan Xu. Bugs: MESOS-7115 https://issues.apache.org/jira/browse/MESOS-7115 Repository: mesos Description ------- Use glog to log EXIT() messages. Diffs ----- 3rdparty/stout/include/stout/exit.hpp 762864afd8f86f7e1f439ef6ea7e3965a5f147d5 Diff: https://reviews.apache.org/r/56681/diff/3/ Testing (updated) ------- make check (Fedora 25) **Example output after this change:** ``` jpeach@jpeach src]$ sudo ./mesos-agent --work_dir=/nothing/here --master=phoney:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR I0516 16:31:34.630625 4987 main.cpp:322] Build: 2017-05-11 11:40:39 by jpeach I0516 16:31:34.630748 4987 main.cpp:323] Version: 1.4.0 I0516 16:31:34.630760 4987 main.cpp:330] Git SHA: 62e0f726198e90d63e9e88156432d833ca88476c I0516 16:31:34.647601 4987 systemd.cpp:238] systemd version `231` detected I0516 16:31:34.647650 4987 main.cpp:432] Inializing systemd state I0516 16:31:34.656100 4987 systemd.cpp:326] Started systemd slice `mesos_executors.slice` I0516 16:31:34.658421 4987 containerizer.cpp:221] Using isolation: posix/cpu,posix/mem,filesystem/posix,network/cni I0516 16:31:34.668910 4987 linux_launcher.cpp:150] Using /sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher I0516 16:31:34.670874 4987 provisioner.cpp:249] Using default backend 'overlay' E0516 16:31:34.684639 4987 main.cpp:461] EXIT with status 1: Failed to create a master detector: Failed to parse 'phoney:5050' ``` **Example output before this change:** ``` [jpeach@jpeach build]$ sudo /opt/mesos/sbin//mesos-agent --work_dir=/nothing/here --master=phoney:5050 WARNING: Logging before InitGoogleLogging() is written to STDERR I0320 11:03:43.868015 1188 main.cpp:243] Build: 2017-03-10 10:49:55 by jpeach I0320 11:03:43.868135 1188 main.cpp:244] Version: 1.3.0 I0320 11:03:43.868151 1188 main.cpp:251] Git SHA: 487c667260ec89127e18c77b9e8c8c243cf6ec57 I0320 11:03:43.886561 1188 systemd.cpp:238] systemd version `231` detected I0320 11:03:43.886631 1188 main.cpp:342] Inializing systemd state I0320 11:03:43.896606 1188 systemd.cpp:326] Started systemd slice `mesos_executors.slice` I0320 11:03:43.899202 1188 containerizer.cpp:221] Using isolation: posix/cpu,posix/mem,filesystem/posix,network/cni I0320 11:03:43.911183 1188 linux_launcher.cpp:150] Using /sys/fs/cgroup/freezer as the freezer hierarchy for the Linux launcher I0320 11:03:43.913216 1188 provisioner.cpp:249] Using default backend 'overlay' Failed to create a master detector: Failed to parse 'phoney:5050' ``` Thanks, James Peach