-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59413/
-----------------------------------------------------------

(Updated May 22, 2017, 4:52 p.m.)


Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil 
Conway.


Changes
-------

Rework patch to only target bytes.hpp.


Summary (updated)
-----------------

Fix bytes.hpp constexpr compilation failure with GCC 7.1.


Bugs: MESOS-7520
    https://issues.apache.org/jira/browse/MESOS-7520


Repository: mesos


Description (updated)
-------

Many of the `constexpr` variables fail to compile with errors such as `error: 
'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it 
refers to an incompletely initialized variable`. 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829

This patch changes around the `Bytes` class a bit by getting rid of the small 
classes that extend `Bytes`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/bytes.hpp 98223db50 


Diff: https://reviews.apache.org/r/59413/diff/4/

Changes: https://reviews.apache.org/r/59413/diff/3-4/


Testing
-------

`./bootstrap && mkdir build && cd build && ../configure --disable-python 
--disable-java --disable-optimize --disable-hardening &&  make -j$(nproc)`


Thanks,

Aaron Wood

Reply via email to