----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/ -----------------------------------------------------------
(Updated May 19, 2017, 6:51 p.m.) Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway. Changes ------- Rebased on the latest HEAD. Bugs: MESOS-7520 https://issues.apache.org/jira/browse/MESOS-7520 Repository: mesos Description ------- Many of the `constexpr` variables fail to compile with errors such as `error: 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because it refers to an incompletely initialized variable`. This patch changes around the `Bytes` class a bit by getting rid of the small classes that extend `Bytes`. Additionally, any usage of the `Duration` class has been adjusted to not instantiate using the base type (which triggers the issue along with `constexpr`). Diffs (updated) ----- 3rdparty/stout/include/stout/bytes.hpp 98223db50 src/master/constants.hpp 7edf9f65f src/sched/constants.hpp 9edb25b38 src/sched/sched.cpp ef73c1dcc src/scheduler/constants.hpp e3da12646 src/slave/constants.hpp 1159ac3b1 src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp cf0466c62 src/slave/slave.cpp 7564e8d39 src/slave/status_update_manager.cpp df63a708c Diff: https://reviews.apache.org/r/59413/diff/2/ Changes: https://reviews.apache.org/r/59413/diff/1-2/ Testing ------- `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make -j$(nproc)` Thanks, Aaron Wood