----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review175745 -----------------------------------------------------------
Ship it! Ship It! - Chun-Hung Hsiao On May 22, 2017, 6:04 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59018/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 6:04 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Supported Image::Secret in docker URI fetcher plugin. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 > > > Diff: https://reviews.apache.org/r/59018/diff/4/ > > > Testing > ------- > > make check > > Manually tested using mesos-execute with task group. Verified that pulling > separate private image from different registries using different image > secrets works correctly. > > > Thanks, > > Gilbert Song > >
