-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/
-----------------------------------------------------------
(Updated May 31, 2017, 8 a.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Addressed review comments.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
If the `SUBSCRIBE` indicates a subset of roles to be suppressed during
framework (re)registration, the allocator does not offer resources for
those roles to such frameworks. Note that this functionality is added
for `v1::SUBSCRIBE` only (and not for scheduler driver API).
In addition, the master validates the suppressed roles to be a subset
of all the roles being (re)registered by the framework.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp
dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7
src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6
src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d
src/master/allocator/mesos/allocator.hpp
119b461136123229f85ed3c3cfd41137974a6b9b
src/master/allocator/mesos/hierarchical.hpp
82fea40ad09c95f0096934c4210a39a6f0638ed9
src/master/allocator/mesos/hierarchical.cpp
ca368bb5ef0dcfe83672004d58a4de6f85d6b4bc
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
src/tests/allocator.hpp 4ea722491f63f5ceda5a47228aafddc020f643b0
src/tests/hierarchical_allocator_tests.cpp
eb2b647d3247a85e8b9b82e5589232c74ad8570f
src/tests/master_allocator_tests.cpp b9e04226a1688499847bc25c7c220c0b82ba8db7
src/tests/persistent_volume_endpoints_tests.cpp
21136b29d7eeee24959527b889f52611baee0668
src/tests/reservation_tests.cpp 47ccf7f6f6ee48236f6794ce3084ce4f425c93c5
src/tests/resource_offers_tests.cpp f0bca1d9e03013ce35215b0ffa6b50b38972dc0c
src/tests/slave_recovery_tests.cpp df0c5c88786190be06df7ef3602834aa8985cefe
Diff: https://reviews.apache.org/r/57817/diff/10/
Changes: https://reviews.apache.org/r/57817/diff/9-10/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
