> On May 31, 2017, 12:09 a.m., Benjamin Mahler wrote: > > src/tests/partition_tests.cpp > > Lines 2387 (patched) > > <https://reviews.apache.org/r/59320/diff/2/?file=1721803#file1721803line2387> > > > > Hm.. why disabled on windows? Do you know why or is this just copied? > > For example, it's not clear to me why the above partition test isn't > > disabled but the below one is.
I don't really have a way to run tests on Windows, and I'm nervous just depending on the Windows reviewbot/CI. I'll try enabling it and see what happens... - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59320/#review176399 ----------------------------------------------------------- On May 16, 2017, 8:19 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59320/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 8:19 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Add an explanatory comment and a test case for a particular case in the > master's logic for handling agent re-registration. > > > Diffs > ----- > > src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad > src/tests/partition_tests.cpp 4ff428564d1fa6cb96e6f8ec8edc331da88a3eb6 > > > Diff: https://reviews.apache.org/r/59320/diff/2/ > > > Testing > ------- > > `make check` > > Checked that if you add `CHECK_NOTNULL(framework)` to the master code (circa > the newly added comment), the incorrect `CHECK` is triggered by this test > case (but not by any existing test cases). > > > Thanks, > > Neil Conway > >
