----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59320/#review176731 -----------------------------------------------------------
Patch looks great! Reviews applied: [59213, 59214, 59215, 59216, 59217, 59218, 59219, 59259, 59301, 59302, 59320] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On May 31, 2017, 8:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59320/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 8:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Add an explanatory comment and a test case for a particular case in the > master's logic for handling agent re-registration. > > > Diffs > ----- > > src/master/master.cpp a5376f9fc3c3c6c72b22cfd36ec56a1de0d03a3a > src/tests/partition_tests.cpp 62a84f797201ccd18b71490949e3130d2b9c3668 > > > Diff: https://reviews.apache.org/r/59320/diff/3/ > > > Testing > ------- > > `make check` > > Checked that if you add `CHECK_NOTNULL(framework)` to the master code (circa > the newly added comment), the incorrect `CHECK` is triggered by this test > case (but not by any existing test cases). > > > Thanks, > > Neil Conway > >
