----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58509/#review177508 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.cpp Lines 1611-1612 (original), 1610-1611 (patched) <https://reviews.apache.org/r/58509/#comment251102> This would become: ``` Resources resources = available.allocatableTo(role); ``` src/master/allocator/mesos/hierarchical.cpp Line 1777 (original), 1775 (patched) <https://reviews.apache.org/r/58509/#comment251103> This would become: ``` Resources resources = available.allocatableToRole(role); if (quotas.contains(role)) { resources -= resources.unreserved(); } ``` - Benjamin Mahler On April 18, 2017, 3:44 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58509/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 3:44 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7149 > https://issues.apache.org/jira/browse/MESOS-7149 > > > Repository: mesos > > > Description > ------- > > Other than looking at reservation made for a role, now allocator also > aggregates reservations of all its ancestor in the hierarchy. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 051f749dd5921a322ca930a042c31814616d38f9 > > > Diff: https://reviews.apache.org/r/58509/diff/1/ > > > Testing > ------- > > see next patch in chain > > > Thanks, > > Jay Guo > >
