> On June 6, 2017, 10:25 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2072-2083 (original), 2072-2093 (patched) > > <https://reviews.apache.org/r/59860/diff/1/?file=1743639#file1743639line2072> > > > > While this code just extends an existing pattern, I wonder why this > > change needs to be done here in the allocator (this filtering is a master > > policy, and not dictated by contraints inherent to this allocator). > > > > I paste my comment from > > https://reviews.apache.org/r/59766/#review176942 verbatim here, > > > > > Have you considered implementing this change outside of the > > allocator? It seems unfortunate that we keep pushing more problem-specific > > workarounds into the allocator which both complicates the > > HierarchicalAllocator and makes implementing custom allocators harder. > > > > > > It seems to me that a filtering policy like this one (and e.g., also > > the work done here for GPUs), could be done just as well e.g., with > > Filters, i.e., for not region-aware frameworks a master could automatically > > inject Filters for all affected agents (this would require some adjustments > > to the effects of revive calls). Alternatively, one could imagine > > augmenting the allocator interface to allow injecting filtering policies > > (e.g., by passing a collection of callbacks).
Right. Thanks for the comment Benjamin. I've left a `TODO` here for now so that we can consider fixing this in the future. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59860/#review177150 ----------------------------------------------------------- On June 6, 2017, 6:54 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59860/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 6:54 p.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7633 > https://issues.apache.org/jira/browse/MESOS-7633 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 > src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 > > > Diff: https://reviews.apache.org/r/59860/diff/1/ > > > Testing > ------- > > New tests + `make check`. > > > Thanks, > > Michael Park > >
