----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178023 -----------------------------------------------------------
include/mesos/resources.hpp Lines 664 (patched) <https://reviews.apache.org/r/60036/#comment251779> Should we also update `v1` version of this header? include/mesos/resources.hpp Lines 667 (patched) <https://reviews.apache.org/r/60036/#comment251778> "`Resource.role` and `Resource.reservation`", not "nor" - Neil Conway On June 15, 2017, 7:39 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60036/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 7:39 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > With reservation refinement, we use the `Resource.reservations` field > to express the reservation state. Due to the fact that `Resource.role` > is an optional field with a default value, our generic Protobuf to > JSON converter prints out the `role` field even if it's not set. > In order to mitigate the confusion for the users, we introduce a hack > for now to conditionally remove the `role` field. > > > Diffs > ----- > > include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db > src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 > src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 > > > Diff: https://reviews.apache.org/r/60036/diff/5/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
