> On June 18, 2017, 6:46 p.m., Neil Conway wrote: > > src/common/http.cpp > > Lines 519 (patched) > > <https://reviews.apache.org/r/60036/diff/9/?file=1752916#file1752916line520> > > > > Backticks not double quotes?
Eh... I'm referring to fields in a JSON object here, I feel like double-quotes are fine. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60036/#review178172 ----------------------------------------------------------- On June 15, 2017, 12:39 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60036/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 12:39 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > With reservation refinement, we use the `Resource.reservations` field to > express the reservation state. Due to the fact that `Resource.role` is > an optional field __and__ has a default value, our generic Protobuf to > JSON code injects the `role` field with the default value even if it's > not set. Since this will likely confuse users, here we manually remove > the `Resource.role` field if the resource has refined reservations. > > > Diffs > ----- > > src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e > src/common/http.cpp 167dce2b9a2d3b68a1df5b4079f701482d34db28 > src/master/http.cpp e01c3fcdc0df63934fc82ee4c9bf081f54cf7ea2 > src/slave/http.cpp 78b35865e465ff1e8e7e4950fdb60e3a48b916b6 > > > Diff: https://reviews.apache.org/r/60036/diff/10/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
