----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59599/#review178732 -----------------------------------------------------------
LGTM so far. Having some patch using this functionality immediately following would be great. - Benjamin Bannier On June 9, 2017, 1:18 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59599/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 1:18 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, > Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-7560 > https://issues.apache.org/jira/browse/MESOS-7560 > > > Repository: mesos > > > Description > ------- > > Added 'type' and 'name' fields to ResourceProviderInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc > include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402 > > > Diff: https://reviews.apache.org/r/59599/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >