> On June 22, 2017, 10:01 a.m., Armand Grillet wrote: > > src/cli_new/pylint.config > > Lines 16 (patched) > > <https://reviews.apache.org/r/60353/diff/1/?file=1757981#file1757981line16> > > > > I do not think that having a pylint.config for all our Python > > directories in src/cli_new is the most logical solution. We could move > > pylint.config to support/ in this review request or add a new PyLint > > configuration, including a new pylint.config, for these support scripts. It > > will require a change in the `run_lint` method of `PyLinter` to use > > different settings when linting the directories. > > > > I would go for the second solution due to some errors currently > > returned by PyLint when linting files such as support/post-reviews.py, e.g. > > `E: 53, 0: No name 'version' in module 'distutils' (no-name-in-module)` > > that is likely due to the `virtualenv_dir` used by PyLint (the one used for > > `cli_new`). We are likely need at least two separate settings depending on > > what we lint: a standard Python module or a list of scripts.
+1. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60353/#review178638 ----------------------------------------------------------- On June 22, 2017, 2:57 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60353/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 2:57 a.m.) > > > Review request for mesos, Armand Grillet and Benjamin Bannier. > > > Bugs: MESOS-6390 > https://issues.apache.org/jira/browse/MESOS-6390 > > > Repository: mesos > > > Description > ------- > > None of our support scripts are intended to be used as modules, so > the usage of dashes in the filenames are acceptable. PyLint however > considers dashes in module names (same as the filename) to be an error. > > This commit also adds the `support` directory to the list of linted > sources. > > > Diffs > ----- > > src/cli_new/pylint.config 63fbb94fbf47cccd1053b4c1eafac18b88dbc818 > support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec > > > Diff: https://reviews.apache.org/r/60353/diff/1/ > > > Testing > ------- > > This shouldn't be commited yet as a few support scripts don't pass the linter > yet. > > > Thanks, > > Joseph Wu > >
