----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review180752 -----------------------------------------------------------
support/mesos-style.py Lines 309-319 (original), 325-335 (patched) <https://reviews.apache.org/r/60900/#comment255965> this can be done with less duplication: ``` process = subprocess.Popen( [('. {virtualenv_dir}/bin/activate;' ' PYTHONPATH={lib_dir}:{bin_dir} pylint' ' --rcfile={pylint} --ignore={ignore} {files}'). format(files=source_files, **source_config)], shell=True, stdout=subprocess.PIPE) ``` - Eric Chung On July 16, 2017, 7:34 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60900/ > ----------------------------------------------------------- > > (Updated July 16, 2017, 7:34 p.m.) > > > Review request for mesos, Eric Chung and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This allows us to have different Pylint configurations > depending on the directory we lint. This will be useful > in the future to lint our standard Python packages and > the list of scripts in support/ differently. > > > Diffs > ----- > > src/python/cli_new/pylint.config > support/mesos-style.py 48d816f72df65d77364769f812fc06afcd6b5aec > > > Diff: https://reviews.apache.org/r/60900/diff/1/ > > > Testing > ------- > > Updated a file in src/python/cli_new and checked that the linter was working > as before. > > > Thanks, > > Armand Grillet > >
